On Sun, 2009-01-18 at 17:04 +0100, Hannes Eder wrote:
> >> /**
> >> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> >> index 7c36f16..c0cfe39 100644
> >> --- a/drivers/gpu/drm/drm_modes.c
> >> +++ b/drivers/gpu/drm/drm_modes.c
> >> @@ -357,9 +357,9 @@ EXPORT_SYMBOL(drm_mode_validate_size);
> >> * sure each mode falls within a given range (defined by @min and @max
> >> * arrays) and sets @mode->status as needed.
> >> */
> >> -void drm_mode_validate_clocks(struct drm_device *dev,
> >> - struct list_head *mode_list,
> >> - int *min, int *max, int n_ranges)
> >> +static void drm_mode_validate_clocks(struct drm_device *dev,
> >> + struct list_head *mode_list,
> >> + int *min, int *max, int n_ranges)
> >> {
> >> struct drm_display_mode *mode;
> >> int i;
> >> @@ -376,7 +376,6 @@ void drm_mode_validate_clocks(struct drm_device *dev,
> >> mode->status = MODE_CLOCK_RANGE;
> >> }
> >> }
> >> -EXPORT_SYMBOL(drm_mode_validate_clocks);
> >
> > ??
>
> In both cases: a grep over the entire kernel tree shows that the
> function is only used within the compilation unit it is defined,
> therefore make it static and un-EXPORT it.
If it is EXPORTED you cannot make it static. EXPORTED means it can be
used from a kernel module.
you need to define the declaration of these functions on related header
file to fix these sparse warnings.
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
