On Thursday 03 January 2008 01:32:13 Benjamin Herrenschmidt wrote:
> > Do you think that a solution like:
> >
> > [...]
> > if (rinfo->mon1_EDID) {
> > ret = sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
> > if (ret != 0)
> > printk( KERN_WARNING "radeonfb (%s): cannot create edid1 bin file\n",
> > pci_name(rinfo->pdev));
> > }
> > [...]
> >
> > would be acceptable in this case?
> >
> > If you agree, I could re-submit the patch modified.
>
> Bloat bloat bloat...
>
> Ben.
>
I have to agree with you that my first proposal (avoid creating
the framebuffer in case of a problem in the creation of a sysfs file)
was a little bit "drastic" measure.
I thought that at least the user should be aware that something went
wrong in the driver initialization and that not all the features
will be available at run-time.
That's why I tried to add a specific warning message.
Anyway, I didn't intend to waste so much of your time with my patch
submission.
Sorry for that.
Leonardo
-
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
