On Wednesday 02 January 2008 21:19:33 Benjamin Herrenschmidt wrote:
>
> On Wed, 2008-01-02 at 19:01 +0100, Leonardo Potenza wrote:
> > From: Leonardo Potenza <lpotenza@xxxxxxxxx>
> >
> > Added a check for the sysfs_create_bin_file() return value
> >
> > Signed-off-by: Leonardo Potenza <lpotenza@xxxxxxxxx>
>
> NACK.
>
> The warnings are stupid, this is a long argument we had with akpm among
> others, I totally refuse to fail creating the framebuffer because
> something went bonkers creating some sysfs file that are in no way
> mandatory for the good operations of the fb.
>
> There is a _shitload_ of cases where testing the result of those sysfs
> calls is pure bloat.
>
> Ben.
Sorry, I missed the former discussion.
Do you think that a solution like:
[...]
if (rinfo->mon1_EDID) {
ret = sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
if (ret != 0)
printk( KERN_WARNING "radeonfb (%s): cannot create edid1 bin file\n",
pci_name(rinfo->pdev));
}
[...]
would be acceptable in this case?
If you agree, I could re-submit the patch modified.
Thanks.
Leonardo
-
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
