From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Date: Thu, 03 Jan 2008 07:19:33 +1100 > > On Wed, 2008-01-02 at 19:01 +0100, Leonardo Potenza wrote: > > From: Leonardo Potenza <lpotenza@xxxxxxxxx> > > > > Added a check for the sysfs_create_bin_file() return value > > > > Signed-off-by: Leonardo Potenza <lpotenza@xxxxxxxxx> > > NACK. > > The warnings are stupid, this is a long argument we had with akpm among > others, I totally refuse to fail creating the framebuffer because > something went bonkers creating some sysfs file that are in no way > mandatory for the good operations of the fb. > > There is a _shitload_ of cases where testing the result of those sysfs > calls is pure bloat. I agree. In fact my first reaction to this patch is "Damn, I better test to make sure I don't lose my console on my workstation because of this stupid patch." Just put (void)'s there or whatever, or we should get rid of the mustcheck annotations. Either way is fine with me. - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
