On Tue, Feb 25, 2020 at 12:59:25PM -0800, Nick Desaulniers wrote: > On Mon, Feb 24, 2020 at 8:16 PM Nathan Chancellor > <natechancellor@xxxxxxxxx> wrote: > > > Should this also include an update to Documentation/process/changes.rst > > > with the minimum version required? (I would expect this to be "9" for Clang, > > > and "11" for ld.lld.) > > > > I think the clang one should be added in a separate patch that > > solidifies that in include/linux/compiler-clang.h with a CLANG_VERSION > > macro and version check, like in include/linux/compiler-gcc.h. > > > > ld.lld's minimum version should also be 9, what is the blocking issue > > that makes it 11? > > I'm super hesitant to put a minimally required version of Clang, since > it really depends on the configs you're using. Sure, clang-9 will > probably work better than clang-4 for some configs, but I would say > ToT clang built from source would be even better, as unrealistic as > that is for most people. The question of "what's our support model" > hasn't realistically come up yet, so I don't really want to make a > decision on that right now and potentially pigeonhole us into some > support scheme that's theoretical or hypothetical. We need to expand > out the CI more, and get more people to even care about Clang, before > we start to concern ourselves with providing an answer to the question > "what versions of clang are supported?" But it's just a strong > opinion of mine, held loosely. > > Either way, it can be done (or not) in a follow up patch. I would > like to land some Documentation/ even if it's not perfect, we can go > from there. > -- > Thanks, > ~Nick Desaulniers I think the question of support model is something that we are going to have to sit down and figure out sooner rather than later, especially if we are adding this file to the Documentation; we are saying that this IS supported in some fashion, we need to be able to answer how we are going to resolve issues and what versions can be adequately expect to work with the kernel. I think that being able to tell people to update is not unreasonable, given how efficient we are getting fixing into clang. However, clang's release model is definitely different from gcc's and that can make getting fixes into the hands of regular users harder, aside from asking them to build their own version, which again, is not that difficult and hard to do with something like tc-build. I agree this should happen in a follow up patch. I think starting with clang-9 and saying if anything older works, cool, otherwise update is probably a decent initial model. Cheers, Nathan
