On Wed, Feb 26, 2020 at 01:33:13PM +0100, Sedat Dilek wrote: > On Wed, Feb 26, 2020 at 1:01 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Wed, Feb 26, 2020 at 5:52 AM Nick Desaulniers > > <ndesaulniers@xxxxxxxxxx> wrote: > > > > > > On Mon, Feb 24, 2020 at 4:34 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > > > On Tue, Feb 25, 2020 at 2:41 AM Nick Desaulniers > > > > <ndesaulniers@xxxxxxxxxx> wrote: > > > > > > > > > > Added to kbuild documentation. Provides more official info on building > > > > > kernels with Clang and LLVM than our wiki. > > > > > > > > > > Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx> > > > > > Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > > > > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > > --- > > > > > > > > > > > > Perhaps, is it better to explicitly add it to MAINTAINERS? > > > > > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -4118,6 +4118,7 @@ W: https://clangbuiltlinux.github.io/ > > > > B: https://github.com/ClangBuiltLinux/linux/issues > > > > C: irc://chat.freenode.net/clangbuiltlinux > > > > S: Supported > > > > +F: Documentation/kbuild/llvm.rst > > > > K: \b(?i:clang|llvm)\b > > > > > > I'm happy to leave it to the maintainers of Documentation/. Otherwise > > > we have a file for which there is no MAINTAINER, which seems > > > ambiguous. > > > > It is common that MAINTAINERS lists per-file (per-driver) maintainers. > > It does not necessarily mean a person who picks up patches. > > > > scripts/get_maintainer.pl lists maintainers that > > match any F:, N:, K: patterns. > > So, both Doc and Kbuild maintainers/ML will still be listed. > > > > Having said that, it is up to you. Either is fine with me. > > Another pattern 'K: \b(?i:clang|llvm)\b' covers this file anyway. > > > > > > (BTW, I am also happy to see your name as the maintainer of this entry.) > > > > +1 (Please drop the BTW - This was suggested in the brainstorming > session on the ClangBuiltLinux Meetup in Zurich). > > I suggest to add Nathan and Kees if they are willing to be responsible > for the maintainer job. > > - Sedat - I would not mind having my name added under this MAINTAINERS entry but I definitely think that is a conversation for a different thread. Cheers, Nathan
