Hi, On Tue, May 24, 2011 at 4:46 PM, Hiromu Yakura <hiromu1996@xxxxxxxxx> wrote: > [...] > conf_write() is called after the configure changed. > So I don't think we should handle the failed case of conf_write() > because the purpose of this patch is not to losing changes. > Then your patch is incomplete. only open(2) and write(2) can fail in more than 30 different ways, you check 1. - Arnaud ps: I am not even addressing the race-condition introduced by your patch... -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
