On Tue, May 24, 2011, at 2:59, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote: > Hi, > > On Tue, May 24, 2011 at 1:38 PM, Hiromu Yakura <hiromu1996@xxxxxxxxx> wrote: > > On Tue, May 24, 2011, at 0:50, Arnaud Lacombe <lacombar@xxxxxxxxx> > > wrote: > >> On Tue, May 24, 2011 at 11:01 AM, Michal Marek <mmarek@xxxxxxx> wrote: > >> > I see, qconf lacks a check for the return value of conf_write() in > >> > ConfigMainWindow::closeEvent(), gconf does check the return value, but only > >> > displays it in the bottom box of the main window instead of a message box. > >> > Neither of them return failure in the error case. These bugs should be > >> > indeed fixed. > >> > > >> agree. > >> > >> > But I don't like the directory permission check, it only > >> > handles one case, but does not handle permission on the .config file itself > >> > with KCONFIG_OVERWRITECONFIG=1, ENOSPC and so on. > >> > > >> seconded. > > I'm sorry for forgetting to handle a case which was set KCONFIG_OVERWRITECONFIG. > > So I rewrote the patch and attach it. > > > > Thanks for your advice. > > > > Signed-off-by: Hiromu Yakura <hiromu1996@xxxxxxxxx> > > > Let me re-state: your patch does not handle all the case where > conf_write() may fails, and I do not think we want to preemptively > check for all errors open(2) may return. conf_write() is called after the configure changed. So I don't think we should handle the failed case of conf_write() because the purpose of this patch is not to losing changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
