Hello, On Fri, May 24, 2011 at 22:23, Michal Marek <mmarek@xxxxxxx> wrote: > Arnaud's point is that your patch should not be necessary at all, > because kconfig already checks the return value of the fopen() call in > conf_write() and prints the above message if it fails. So do you have a > testcase where make <...>config without your patch returns without > error, but the configuration is not written? Sorry for misunderstanding. Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...) raise error. And only xconfig and gconfig don't write the configuration without error. However, make *config using 'conf' hasn't function of 'Save as'. In other words, if you don't set the write permission to the directory, you would lose changes of the configuration. I think that it is necessary to check permission at all so that kconfig warn of the possibility of losing changes. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
