Re: [2.6 patch] kconfig-language.txt: remove bogus hint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adrian Bunk wrote:
On Sun, May 04, 2008 at 10:25:57AM -0700, Randy Dunlap wrote:
Sam Ravnborg wrote:
On Sun, May 04, 2008 at 03:10:14PM +0300, Adrian Bunk wrote:
On Sun, May 04, 2008 at 01:27:41PM +0200, Sam Ravnborg wrote:
On Sun, May 04, 2008 at 11:01:37AM +0300, Adrian Bunk wrote:
On Sun, May 04, 2008 at 08:17:41AM +0200, Sam Ravnborg wrote:
On Sun, May 04, 2008 at 02:15:35AM +0300, Adrian Bunk wrote:
This kconfig construct described here is required in a different and much more complicated situation.
Please elaborate...
In the hint C is described as a tristate.

But you need this idiom only when A is a tristate and C is a bool.
Thats another case.
What is described is following simple situation:

config FOO
        bool "Modules"
        option modules

config A
        tristate "a"

config B
        tristate "b"
        depends on A

config C
        tristate "c"
        depends on B
        depends on A = y || A = B


C uses a symbol defined by A - let us name it foo().
If C is build-in and A is a module => link error - unable to resolve foo.

So we say: if A is buildin C may be built-in or module.
if A is a module C may not be built-in.

This is what this hint describes.
In your example C does not need any dependency on A at all since it is already handled through the dependency chain C->B->A.
You are right.
Randy - what problem was it this text tried to describe/solve?
I thought that it was related to USB_STORAGE, but I don't find it
in current kernels.

If the text is misleading, it should be yanked, of course.
And other places checked, e.g.:
...

The idiom has use cases, but you need the following prerequisites:
- A and B are tristates
- B does not depend on A
- C is a bool with the semantics "enable feature C in B"

And I doubt you can put that into a useful hint.

OK, sounds like the patch is good then.

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux