On Mon May 22, 2023 at 10:40 AM EEST, Péter Ujfalusi wrote: > > On 18/05/2023 23:24, Péter Ujfalusi wrote: > > > > The version is used to differentiate the revisions of the UPX-i11 > > boards, and this issue present in all revisions. > > > >> I can squash this to the commit I pushed (it is not yet mirrored > >> to linux-next), if I get the dmidecode info. > > > > System Information > > Manufacturer: AAEON > > Product Name: UPX-TGL01 > > Version: V1.0 > > Serial Number: Default string > > UUID: a300091d-fb1c-ce1c-1d30-0007328efc11 > > Wake-up Type: Power Switch > > SKU Number: Default string > > Family: Default string > > > > I have used this description as it it is used for SOF, probably > > DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01") > > should be added? > > Jarkko: I have tested that adding the > DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01") > works. > > I would also do a small update to commit message: "120000 jiffies" to > "120000 msec". > On my setup 120000 msec ends up to be 120000 jiffies. > > How do you prefer to handle this? > I can send a v2 on top of linux-next / mainline > I can send a fixup patch which can be squashed to the patch you have in > your master branch atm > Or you add this line by yourself? > > Either way is fine for me, whichever works best for you. If you want to send a follow-up please do, and I can pick it. BR, Jarkko
