On 18/05/2023 21:53, Jarkko Sakkinen wrote:
> On Thu May 18, 2023 at 9:50 PM EEST, Jerry Snitselaar wrote:
>> On Wed, May 17, 2023 at 03:29:31PM +0300, Peter Ujfalusi wrote:
>>> The interrupts initially works on the device but they will stop arriving
>>> after about 200 interrupts.
>>>
>>> On system reboot/shutdown this will cause a long wait (120000 jiffies).
>>>
>>> The interrupts on this device got enabled by commit
>>> e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
>>>
>>> Prior to this point the interrupts were not enabled on this machine.
>>>
>>> Complements: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
>>> ---
>>> Hi,
>>>
>>> This patch applies on top of mainline since 6.4-rc1 takes about 2 minutes to
>>> reboot on this machine, linux-next have
>>> e7d3e5c4b1dd tpm/tpm_tis: Disable interrupts for more Lenovo devices
>>>
>>> I'm not sure if I shouold send this on top of next or mainline is fine, please
>>> let me know the preferred way to get this to 6.4.
>>>
>>> Regards,
>>> Peter
>>>
>>> drivers/char/tpm/tpm_tis.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
>>> index 7af389806643..aad682c2ab21 100644
>>> --- a/drivers/char/tpm/tpm_tis.c
>>> +++ b/drivers/char/tpm/tpm_tis.c
>>> @@ -122,6 +122,13 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
>>> DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
>>> },
>>> },
>>> + {
>>> + .callback = tpm_tis_disable_irq,
>>> + .ident = "UPX-TGL",
>>
>> Is this the product version returned by dmidecode? If yes,
>> then the entry could be made more specific by adding a
>> DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"), and only disable
>> for this device instead of any system that matches the vendor
>> AAEON.
The version is used to differentiate the revisions of the UPX-i11
boards, and this issue present in all revisions.
> I can squash this to the commit I pushed (it is not yet mirrored
> to linux-next), if I get the dmidecode info.
System Information
Manufacturer: AAEON
Product Name: UPX-TGL01
Version: V1.0
Serial Number: Default string
UUID: a300091d-fb1c-ce1c-1d30-0007328efc11
Wake-up Type: Power Switch
SKU Number: Default string
Family: Default string
I have used this description as it it is used for SOF, probably
DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
should be added?
Oh, yes, the product name match should be there, we have TigerLake
specific matching, so SOF is looking for AAEON device with TGL.
Sorry for missing this.
>
> BR, Jarkko
--
Péter
