On Mon May 22, 2023 at 11:17 AM EEST, Paul Menzel wrote: > Dear Peijie, > > > Thank you for your patch. > > The fix: tag in your commit message summary is uncommon. I suggest: > > > tpm_tis_spi: Release chip select when flow control fails > > > Am 22.05.23 um 09:01 schrieb shaopeijie@xxxxxxxx: > > From: Peijie Shao <shaopeijie@xxxxxxxx> > > > > The failure paths in tpm_tis_spi_transfer() do not deactivate > > chip select. Send an empty message (cs_select == 0) to overcome > > this. > > Does the standard require to deactivate it? > > A note on your test setup would be nice to have in the commit message. I think it is "good enough", not to say it couldn't be improved. I can accept as it is, or substitute with one with an updated commit message. This is going earliest to v6.5. BR, Jarkko
