On Thu, 2020-10-15 at 08:54 -0400, Ken Goldman wrote:
> On 10/14/2020 6:28 PM, Mimi Zohar wrote:
> >>> Instead of adding a comment here, how about only exporting
> >>> TPM_SERVER_TYPE for "swtpm".
>
> >> That certainly works. I thought the idea was, "Make the
> >> smallest change that fixes the problem." Moving that
> >> line under swtpm is a reasonable alternative.
>
> > In this case, moving the line and adding the comment is the smallest
> > change. To indicate this is a bug fix, you would add "Fixes:
> > f831508297cd ("Install the swtpm package, if available") in addition to
> > your Signed-off-by tag.
> >
>
> The current patch adds one line. This proposal adds one line and
> moves another line. It also changes the swtpm flow, which must
> be tested.
>
> It's OK with me. Let me know.
>
> Where should I add that "Fixes ..." text? What is the exact format?
The "Fixes" tag belongs in the patch description above your Signed-off-
by tag. The format is: Fixes: < commit number> < commit ttitle>
e.g. Fixes: f831508297cd ("Install the swtpm package, if available")
As this is a bug fix, please update the Subject line and post this
change independently of the other changes. I've already tested the
suggested change. Once the updated patch is posted, it will hopefully
be tested by the distros as well.
thanks,
Mimi
