On 10/14/2020 6:28 PM, Mimi Zohar wrote:
Instead of adding a comment here, how about only exporting
TPM_SERVER_TYPE for "swtpm".
That certainly works. I thought the idea was, "Make the
smallest change that fixes the problem." Moving that
line under swtpm is a reasonable alternative.
In this case, moving the line and adding the comment is the smallest
change. To indicate this is a bug fix, you would add "Fixes:
f831508297cd ("Install the swtpm package, if available") in addition to
your Signed-off-by tag.
The current patch adds one line. This proposal adds one line and
moves another line. It also changes the swtpm flow, which must
be tested.
It's OK with me. Let me know.
Where should I add that "Fixes ..." text? What is the exact format?
