On 10/14/2020 6:04 PM, Mimi Zohar wrote:
Hi Ken,
On Mon, 2020-10-12 at 19:44 -0400, Ken Goldman wrote:
The default value raw is appropriate for 'swtpm'. tpm_server
uses the Microsoft packet encapsulation, so the env variable
must have the value mssim.
Signed-off-by: Ken Goldman <kgoldman@xxxxxxxxxx>
Thank you for noticing this regression.
---
tests/boot_aggregate.test | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/boot_aggregate.test b/tests/boot_aggregate.test
index 1c7b1f2..b109a32 100755
--- a/tests/boot_aggregate.test
+++ b/tests/boot_aggregate.test
@@ -35,6 +35,7 @@ else
export TPM_COMMAND_PORT=2321
export TPM_PLATFORM_PORT=2322
export TPM_SERVER_NAME="localhost"
+ # swtpm uses the raw, unencapsulated packet format
export TPM_SERVER_TYPE="raw"
Instead of adding a comment here, how about only exporting
TPM_SERVER_TYPE for "swtpm".
That certainly works. I thought the idea was, "Make the
smallest change that fixes the problem." Moving that
line under swtpm is a reasonable alternative.
I'd leave the comment. I suspect many people
don't know about the Microsoft TPM packet format,
so the line would otherwise be confusing.
fi
@@ -73,6 +74,8 @@ swtpm_start() {
SWTPM_PPID=$!
fi
elif [ -n "${swtpm}" ]; then
+ # tpm_server uses the Microsoft simulator encapsulated packet format
+ export TPM_SERVER_TYPE="mssim"
Exporting TPM_SERVER_TYPE like this is causing openssl/tumbleweed to
fail.
That's odd. Are you saying that openssl uses the env variable
TPM_SERVER_TYPE? What in openssl fails? What's the error
message.
