>From our end we are fine with what Jason suggested, we can add a specific device: 'nuvoton,npct750','tcg,tpm-i2c-ptp' Oshri -----Original Message----- From: Nayna [mailto:nayna@xxxxxxxxxxxxxxxxxx] Sent: Thursday, January 31, 2019 3:46 PM To: IS20 Oshri Alkoby <oshri.alkoby@xxxxxxxxxxx>; IS30 Dan Morav <Dan.Morav@xxxxxxxxxxx>; jgg@xxxxxxxx Cc: IS30 Dana Cohen <dana.cohen@xxxxxxxxxxx>; linux-integrity@xxxxxxxxxxxxxxx; gcwilson@xxxxxxxxxx Subject: Re: device tree "compatible" string value for Nuvoton TPM 75xxx On 01/23/2019 03:22 PM, Nayna wrote: > > > On 01/21/2019 11:55 AM, oshri.alkoby@xxxxxxxxxxx wrote: >> Hi Jason, >> >> Since the driver implements the I2C interface defined by the TCG PTP, >> wouldn't it be better to set the string to be something like >> 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)? >> Any TPM that implements this protocol can use this driver. > > It might be nice to have a generic name if it is also compliant with > the device tree specification. > However, I was wondering if it will not require driver code changes as > well before this generic name can be used by any TPM implementing i2c > protocol ? I am wondering if anything got decided on this ? Thanks & Regards, - Nayna =========================================================================================== The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
