Jason, Thank you for the feedback. We will follow. Regards, Dan. -----Original Message----- From: Jason Gunthorpe <jgg@xxxxxxxx> Sent: Monday, 21 January, 2019 04:27 To: IS30 Dan Morav <Dan.Morav@xxxxxxxxxxx> Cc: nayna@xxxxxxxxxxxxxxxxxx; IS20 Oshri Alkoby <oshri.alkoby@xxxxxxxxxxx>; IS30 Dana Cohen <dana.cohen@xxxxxxxxxxx>; linux-integrity@xxxxxxxxxxxxxxx; gcwilson@xxxxxxxxxx Subject: Re: device tree "compatible" string value for Nuvoton TPM 75xxx On Sun, Jan 20, 2019 at 03:53:46PM +0000, Dan.Morav@xxxxxxxxxxx wrote: > Hi, > > I've added Oshri who has been working on the driver, and Dana who is the TPM applications for follow up. > I'd suggest "npct75x" to continue with the same line. There are rules for the compatible strings.. Generaly they shouldn't include x's if I recall. If future chips are compatible with a first release then it should be something like 'nuvoton,npct751','nuvoton,npct750' Be sure to check with the device tree people Jason =========================================================================================== The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.