On Mon, Jan 21, 2019 at 04:55:23PM +0000, oshri.alkoby@xxxxxxxxxxx wrote: > Hi Jason, > > Since the driver implements the I2C interface defined by the TCG > PTP, wouldn't it be better to set the string to be something like > 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)? Any TPM that > implements this protocol can use this driver. Yes, probably, we've done that for LPC .. But the device compatabile string should still be something like: 'nuvoton,npct751','tcg,tpm-i2c-ptp' In that case Jason