On Monday, May 6, 2024 3:32:20 PM EDT Milas Robin wrote: > Hi, > > I don't think so, I didn't received any reply so I guess it is not ? > If you have some time to review the code I would be grateful. > As I said in the cover letter (which didn't linked correctly), this is > my first kernel module so there might be some basic architecture notably > on race conditions. > > Also due to the way I've implemented it, if it is build as a module > it lose priority over the usb-hid generic driver as the device report > supporting hid it. > > One other thing which might make the code heavier to read is properly > detecting if the controller really support rumbles, I actually ignore the > bit signalling it cause I don't know if the adapter could change it without > unplugging the controller which might lead to have to recreate the device > to switch it's rumbling capability > > The patch seems to have no conflict with the current input/next branch. > If you need a branch I've uploaded it on https://github.com/Hinara/linux.git > The branch is called ngc. I've built the kernel but it won't boot, its likely a issue with my config but could you rebase the patch to a newer kernel. Also I believe we are not contacting the correct person for a merge. https://github.com/torvalds/linux/blob/master/MAINTAINERS#L15595
