On Thu, Apr 04, 2019 at 08:32:55AM +1000, Peter Hutterer wrote: > On Wed, Apr 03, 2019 at 05:40:45PM +0200, Hans de Goede wrote: > > Hi, > > > > On 01-04-19 13:11, Hans de Goede wrote: > > > Hi, > > > > > > On 01-04-19 12:34, Peter Hutterer wrote: > > > > <snip> > > > > > > I noticed you left BTN_TASK in the #defines, any specific reason for that > > > > over using BTN_EXTRA3 for that one? > > > > > > My main focus was making 0x113 some form of back and 0x114 some form of forward > > > and making 0x115/0x116 NOT have back / forward in their names BTN_TASK is 0x117 > > > so I left it alone. But I'm fine with making it BTN_EXTRA3, I agree that would be > > > more consistent. > > > > Peter, any preference for keeping BTN_TASK as is (less churn) vs changing it > > to BTN_EXTRA3 (more consistent) ? > > I'd vote for BTN_EXTRA3 for consistency, doubly so because does *anything* > actually use BTN_TASK for uhm... "task"? whatever that means in this context :) I believe this came from Logitech which had mice with "Task Switch" button. I guess windows driver could convert it to Alt-Tab or similar. http://oyvind.servehttp.com/logitech_mx700.htm Thanks. -- Dmitry
