Hi Benjamin, I tested one of our devices against a 4.19 kernel without hid-jabra configured, and there are still issues with some of our vendor defined usages being mapped to input events. >From the sysfs rdesc: ff30.0020 ---> Key.Btn0 ff30.fffb ---> Key.Btn0 ff30.0097 ---> Key.Btn0 ff30.002a ---> Key.Btn0 ff30.002f ---> Key.Btn0 ff30.0021 ---> Key.Btn0 ff30.0024 ---> Key.Btn0 ff30.fffd ---> Key.Btn0 ff30.0050 ---> Key.Btn0 ff30.00b0 ---> Absolute.Misc ff30.00b1 ---> Absolute.Misc ff30.00b2 ---> Absolute.Misc ff30.00b3 ---> Absolute.Misc ff30.00b4 ---> Absolute.Misc ff30.00b5 ---> Absolute.Misc ff30.00b6 ---> Absolute.Misc ff30.00b7 ---> Absolute.Misc ff30.00b8 ---> Absolute.Misc ff30.00b9 ---> Absolute.Misc ff30.00ba ---> Absolute.Misc ff30.00bb ---> Absolute.Misc ff30.fffc ---> Key.Btn0 Best regards, Niels -----Original Message----- From: Niels Skou Olsen Sent: 24. oktober 2018 09:12 To: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Cc: open list:HID CORE LAYER <linux-input@xxxxxxxxxxxxxxx>; Jiri Kosina <jikos@xxxxxxxxxx> Subject: RE: Do we still need hid-jabra after v4.18? Hi Benjamin, What we see is that the generic input mapping takes some of our vendor defined usages and maps them to various input events, and especially 'Key.Btn0', 'Key.Btn1' et al. cause problems in X sessions. Basically, the generic input mapping should never map vendor defined usages, since they could mean anything. I will look into it and check the latest and greatest against our devices next week, when the release I'm working on is (hopefully) out of my hands. Best regards, Niels -----Original Message----- From: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Sent: 23. oktober 2018 09:40 To: Niels Skou Olsen <nolsen@xxxxxxxxx> Cc: open list:HID CORE LAYER <linux-input@xxxxxxxxxxxxxxx>; Jiri Kosina <jikos@xxxxxxxxxx> Subject: Do we still need hid-jabra after v4.18? Hi Niels, Since 190d7f02ce8e "HID: input: do not increment usages when a duplicate is found", I wonder if hid-jabra is still required. Looking at https://patchwork.kernel.org/patch/9934051/#20904077, it seems hid-jabra only prevents the vendor collection to create multitouch axes, which interferes in X with the generic multitouch handling. I believe libinput should already detect and fix this situation, but also, I believe 190d7f02ce8e will prevent ABS_MISC to be incremented, and so there is no more need for hid-jabra to stay around. Can I ask you to double check if one of your headsets woks with hid-generic on a v4.18 kernel? Cheers, Benjamin **** GN GROUP NOTICE - AUTOMATICALLY INSERTED**** The information in this e-mail (including attachments, if any) is considered confidential and is intended only for the recipient(s) listed above. Any review, use, disclosure, distribution or copying of this e-mail is prohibited except by or on behalf of the intended recipient. If you have received this email in error, please notify me immediately by reply e-mail, delete this e-mail, and do not disclose its contents to anyone. Any opinions expressed in this e-mail are those of the individual and not necessarily the GN group. Thank you. ******************** DISCLAIMER END ************************
