On Tue, 24 Jul 2018 13:54:56 +0200 Hanno Zulla <abos@xxxxxxxx> wrote: > HID: hid-sony: Only allow four LED states to identify controller > > The PS3 and PS4 consoles only support four game controllers, while > Linux supports any number of game controller connected to it. The > kernel driver should mirror the original console's behaviour here > and leave the use of additional LED patterns/colours to user space. > Hi Hanno, JFYI the PS3 officially supports up to 7 controllers, quoting the PS3 Quick reference Guide[1]: You can connect up to 7 controllers at one time. The controller number is shown by the number above the port indicators. For numbers 5-7, add the numbers of the lit indicators. The 10 patterns in the linux driver were added following this "addition" rule, extrapolating it up to 10 by using all the 4 LEDs. Equivalent code was in the bluez sixaxis plugin[2] too but it was removed since the kernel started handling the controller numbering. If Sony developers really prefer this code removed I am not necessarily against it, they are the maintainers now after all, however I wanted to point out the history behind the code. I have no comments about the PS4 part. Ciao, Antonio [1] https://www.playstation.com/manual/pdf/CECHJ02_03-2.30_2.pdf See pag. 17 on this version of the guide. [2] https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/plugins/sixaxis.c?id=efe53dc46f0ebcfbe7d03f21fe52b5720f39ec59 -- Antonio Ospite https://ao2.it https://twitter.com/ao2it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
