On Fri, Jun 15, 2018 at 6:14 AM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> On Wed, 13 Jun 2018, Frank Praznik wrote:
>
>> >> While blue/red/green/pink are bright, the RGB values for orange/teal/white
>> >> were rather dark in comparison. This increases the RGB brightness for
>> >> color values 4-6.
>> >>
>> >> Signed-off-by: Hanno Zulla <kontakt@xxxxxxxx>
>> >> ---
>> >> drivers/hid/hid-sony.c | 6 +++---
>> >> 1 file changed, 3 insertions(+), 3 deletions(-)
>> >>
>> >> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
>> >> index e475c5073c99..65af382f7394 100644
>> >> --- a/drivers/hid/hid-sony.c
>> >> +++ b/drivers/hid/hid-sony.c
>> >> @@ -1830,9 +1830,9 @@ static void dualshock4_set_leds_from_id(struct sony_sc *sc)
>> >> /* Red */ { 0x40, 0x00, 0x00 },
>> >> /* Green */ { 0x00, 0x40, 0x00 },
>> >> /* Pink */ { 0x20, 0x00, 0x20 },
>> >> - /* Orange */ { 0x02, 0x01, 0x00 },
>> >> - /* Teal */ { 0x00, 0x01, 0x01 },
>> >> - /* White */ { 0x01, 0x01, 0x01 }
>> >> + /* Orange */ { 0x40, 0x20, 0x00 },
>> >> + /* Teal */ { 0x00, 0x20, 0x20 },
>> >> + /* White */ { 0x20, 0x20, 0x20 }
>> >
>> > Let's add Frank to CC (who came up with the original values). Frank, any
>> > word to this?
>>
>> They were all darker at the beginning. When Roderick Colenbrander at
>> Sony was working on the driver he changed the first four values to be
>> brighter, probably to match the values used on the Playstation 4.
>
> Alright, let's add Roderick as well :)
>
Correct, the 4 original colors (red, green, blue, purple) are the
values of the official platform, which we wanted to use. The official
platform supports 4 controllers, so there are no official colors
passed the official 4. Honestly more than 4 is a little academic.
Though if adding other colors, I'm not sure how bright to make them as
it affects battery life. For consistency reason I would probably have
the sum of other colors be ~0x40 to have similar battery life.
Thanks,
Roderick
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
