On Fri, 10 Feb 2017, Todd Kelner wrote: > Sony's NSG-MR5U and NSG-MR7U remote controls have a full keyboard and a > touchpad. The keyboard is already supported by the existing Linux kernel > and drivers but the touchpad is not recognized. This patch adds the code > needed to bring full functionality to the touchpad. > > Note that these remotes use the vendor code for SMK even though they are > Sony branded. Ouch, sorry for missing this. I've just found this patch hiding in a dark corners of my inbox. [ ... snip ... ] > /* We map the button underneath the touchpad to BTN_LEFT. */ > __set_bit(EV_KEY, sc->touchpad->evbit); > __set_bit(BTN_LEFT, sc->touchpad->keybit); > + __clear_bit(BTN_MIDDLE, sc->touchpad->keybit); > + __clear_bit(BTN_RIGHT, sc->touchpad->keybit); Could you please explain (perhaps in a comment and/or commitlog) why this change is okay even in !(sc->quirks & NSG_MRXU_REMOTE) cases? Otherwise the patch looks good to me; if you could please rebase it on top of current codebase, I'll merge it immediately. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
