Re: [PATCH] input: keyboard: constify attribute_group structures.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 5, 2017 at 12:46 PM, Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote:

> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
>    text    data     bss     dec     hex filename
>    5693     464       0    6157    180d drivers/input/keyboard/gpio_keys.o
>
> File size After adding 'const':
>    text    data     bss     dec     hex filename
>    5749     400       0    6149    1805 drivers/input/keyboard/gpio_keys.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux