Re: [PATCH 6/9] input: goodix: write configuration data to device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 28, 2015 at 01:47:42PM +0100, Irina Tirdea wrote:
> Goodix devices can be configured by writing this information
> to the device at init. The configuration data can
> be provided through the ACPI/device tree property
> "device-config". If "device-config" is not set, the default
> device configuration will be used.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@xxxxxxxxx>
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
> ---
>  .../bindings/input/touchscreen/goodix.txt          |   5 +
>  drivers/input/touchscreen/goodix.c                 | 143 +++++++++++++++++++++
>  2 files changed, 148 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index 7137881..9e4ff69 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -15,6 +15,11 @@ Required properties:
>   - irq-gpio		: GPIO pin used for IRQ
>   - reset-gpio		: GPIO pin used for reset
>  
> +Optional properties:
> +
> + - device-config	: device configuration information (specified as byte
> +			  array). Maximum size is 240 bytes.

Generally we frown on passing opaque data.

What exactly is encoded in device-config? The description is very vague.

Does this correspond to anything in a data sheet or manual?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux