On Sat, Aug 17, 2013 at 10:53:05AM +0400, Alexander Shiyan wrote: > On Sat, 17 Aug 2013 08:20:12 +0200 > Michael Grzeschik <mgr@xxxxxxxxxxxxxx> wrote: > > > On Sat, Aug 17, 2013 at 09:46:20AM +0400, Alexander Shiyan wrote: > > > This patch is a preparation mc13xxx powerbutton driver to support > > > MC13892 and support the probe through the DT. > > > > As this patch already mention by itself, it's doing to much at once. > > And by looking at it, it realy does more than it tells here. > > > > Can you rework that into seperate readable tasks. In this patch you > > nearly rewrite the whole file. That runs the review impossible. > > All changes in this patch are addicted to each other, can not be divided. I find this hard to believe. Here are some changes that can be separated easily: - Rename defines from MC13XXX_BUTTON_ to MC13783_BUTTON_ - convert module_platform_driver to module_platform_driver_probe, why do you change this anyway? - convert from kzalloc to devm_kzalloc - rewrite error message from "missing platform data" to "Missing platform data" Drop these changes or make them separate patches and your original patch would be smaller already. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
