On Sat, 17 Aug 2013 08:20:12 +0200 Michael Grzeschik <mgr@xxxxxxxxxxxxxx> wrote: > On Sat, Aug 17, 2013 at 09:46:20AM +0400, Alexander Shiyan wrote: > > This patch is a preparation mc13xxx powerbutton driver to support > > MC13892 and support the probe through the DT. > > As this patch already mention by itself, it's doing to much at once. > And by looking at it, it realy does more than it tells here. > > Can you rework that into seperate readable tasks. In this patch you > nearly rewrite the whole file. That runs the review impossible. All changes in this patch are addicted to each other, can not be divided. As an alternative, I can do all as a new driver. Thanks. -- Alexander Shiyan <shc_work@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html