Dmitry Torokhov wrote: >> The patch disables the interrupt handler on shutdown. >> >> One of our customers reported a bug caused by input events being generated >> during shutdown (for example if the user was touching the device whilst it >> was turning off), which was solved by putting in this change. > > What kind of bug? Could you please be more precise? I did some more digging. Unfortunately the original problem report (some time around March 2012) was in a customer ticket system that I no longer have access to. It could well be trying to paper over a problem in their app layer, to be honest. >> However, now you've drawn my attention to it again, it seems to me that >> probably a better thing for us to be doing would be to power off the >> touchscreen controller here, and let the interrupt disable be handled by >> core code - do you agree? > > We'd be powering off everything in a moment anyway, no? Or is there a > concern that the device will stay powered up even if the system is in off > state? I agree. I think it's best to not apply this patch for the moment, until we can prove it's actually required. Let me know if you want me to generate a new pull request. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
