On Mon, Jul 08, 2013 at 10:56:06AM +0100, Nick Dyer wrote: > Dmitry Torokhov wrote: > > On Thu, Jun 27, 2013 at 01:48:57PM +0100, Nick Dyer wrote: > >> Signed-off-by: Nick Dyer <nick.dyer@xxxxxxxxxxx> > >> Acked-by: Benson Leung <bleung@xxxxxxxxxxxx> > > > > Why is this needed? > > The patch disables the interrupt handler on shutdown. > > One of our customers reported a bug caused by input events being generated > during shutdown (for example if the user was touching the device whilst it > was turning off), which was solved by putting in this change. What kind of bug? Could you please be more precise? > > However, now you've drawn my attention to it again, it seems to me that > probably a better thing for us to be doing would be to power off the > touchscreen controller here, and let the interrupt disable be handled by > core code - do you agree? We'd be powering off everything in a moment anyway, no? Or is there a concern that the device will stay powered up even if the system is in off state? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html