Hi Henrik, > > > I am seeing _new_ irrelevant changes in this version... There is no > > > need to revert to v3. Just remove the synaptics_rmi4_query_function() > > > changes and other uneeded cruft from the v4 patch. No new changes, > > > please, and make sure the final patch is tested. > > > > Those changes are intended to fix line over 80 characters in v3. > > The code has been optimized and the logic does not change. > > I would still prefer if the trivial non-functional changes were > deferred to later patches. I realize that the change from 'TOUCHPAD' > to 'TOUCHSCREEN' created some problems, but those changes were not > called for in the first place. How about leaving those lines be for > now, and then change to something more generic in a later patch? The > code will obviously work equally well for both touchpad and > touchscreen settings, so the defines could be better named anyways. > > > Patch v5 has been verified with pandaboard. > > Thank you. > > Henrik I see. As your suggestions in patch v5, I will resend patch containing only functional changes. Thanks for your advice. Alexandra -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
