On Mon, 24 Sep 2012 22:13:35 -0400 David Dillow <dave@xxxxxxxxxxxxxx> wrote: > On Mon, 2012-09-24 at 09:56 -0400, David Dillow wrote: > > On Mon, 2012-09-24 at 13:25 +0200, Antonio Ospite wrote: > > > In order to make this work I have to put joypad buttons only in one of > > > the key maps, I don't know if that is compatible with the Harmony > > > adapter. > > > > I suspect it is, but I'll try to test later tonight. Feel free to merge > > my patch and yours and push it upstream under your name/copyright; I'm > > not attached to it. > > Yep, this works with the Harmony. > Good. I will send a v3 then, with you as the main author (the From: field) and with myself added in the MODULE_AUTHOR section, this looks like the best way to me as you are the initial author. I'd like you to take a final look at that one tho, and maybe do an actual test too. I will add the note about the "setup" procedure too. > I think the logic you are using may result in some combinations being > missed -- say Triangle + Play -- but I'm not sure how much it matters. Yes, when pressing something like Triangle+Play the Play pressure is completely ignored as a 0xff is reported in the 5th byte, but it's the hardware which behaves that way, the driver is just very adherent to what the hardware provides. > I > can rework the first version (building a custom report based on the > funky rules of coding) in the next few days, or you can push your > version if you'd like. Or perhaps a middle way, that erases the buttons > reported in the bitmap from the byte array, but otherwise keeps track of > the last press in that area to avoid weirdness when the user presses a > button combo that cannot be reported due to the HW limitations. > I'd say we ignore this fact and not try to be too smart here, the hardware has the limitation so we can blame someone else. Does that make sense to you? Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
