RE: [PATCH 1/2] input:Regulator support in ROHM BU21013 touch panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

>>
>> >On Wed, Jan 12, 2011 at 12:05:26PM +0530, Naveen Kumar G wrote:
>> >> @@ -456,6 +459,16 @@ static int __devinit bu21013_probe(struct
>> >i2c_client *client,
>> >>  	bu21013_data->in_dev = in_dev;
>> >>  	bu21013_data->chip = pdata;
>> >>  	bu21013_data->client = client;
>> >> +	dev_set_name(&client->dev, pdata->name);
>> >
>> >Hmm, why is this needed?
>> >
>> Actual name of the client device is 3-005c, which is not clearly
>understand.
>> So, in our project line we are setting the device name from platform
>data.
>>
>
>So who/what cares about I2C device name? I do not see how this help
>anything, but it does make device's name differ from its sysfs name.
>
>I believe that driver should only alter names of objects they create and
>leave other objects alone.
>

In our regulator driver platform data, we used to differentiate with device name,
which is more readable than the client device name. That is why we are sending it through platform data.
If you are not preferable to use this, we could change it to client device name.

Thanks & Regards,
Naveen
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux