Hi Naveen, On Wed, Jan 12, 2011 at 12:05:26PM +0530, Naveen Kumar G wrote: > @@ -456,6 +459,16 @@ static int __devinit bu21013_probe(struct i2c_client *client, > bu21013_data->in_dev = in_dev; > bu21013_data->chip = pdata; > bu21013_data->client = client; > + dev_set_name(&client->dev, pdata->name); Hmm, why is this needed? > + > + bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH"); > + if (IS_ERR(bu21013_data->regulator)) { > + dev_warn(&client->dev, "regulator_get failed\n"); > + bu21013_data->regulator = NULL; > + } > + if (bu21013_data->regulator) > + regulator_enable(bu21013_data->regulator); > + I believe Mark prefers to fail initialization if regulator isn't found/available and use dummy regulators on platforms that do not have real one. Mark? -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html