On Wed, Jan 12, 2011 at 10:05:07AM +0100, Naveen Kumar GADDIPATI wrote: > Hi Dmitry, > > > >On Wed, Jan 12, 2011 at 12:05:26PM +0530, Naveen Kumar G wrote: > >> @@ -456,6 +459,16 @@ static int __devinit bu21013_probe(struct > >i2c_client *client, > >> bu21013_data->in_dev = in_dev; > >> bu21013_data->chip = pdata; > >> bu21013_data->client = client; > >> + dev_set_name(&client->dev, pdata->name); > > > >Hmm, why is this needed? > > > Actual name of the client device is 3-005c, which is not clearly understand. > So, in our project line we are setting the device name from platform data. > So who/what cares about I2C device name? I do not see how this help anything, but it does make device's name differ from its sysfs name. I believe that driver should only alter names of objects they create and leave other objects alone. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
