Hi Paul, On Wed, Nov 24, 2010 at 1:09 AM, Paul Mundt <lethal@xxxxxxxxxxxx> wrote: > On Tue, Nov 23, 2010 at 07:48:21AM -0800, Kevin Hilman wrote: >> [...] >> Agreed. In general, we should not have machine/platform specific >> conditionals in generic Kconfigs. Generally, this should be handled in >> machine/platform specific Kconfigs. >> > The patch that I originally wrote for this had the select under the > Kconfig option for the driver itself, with the decision to use it or not > being dynamically determined based on the platform data. I maintain that > this is the only sensible way to deal with things, but this was rejected > by the input folks at the time who felt that it was adding in extra > overhead for a corner case. The alternatives then are to either make an > identical copy of the driver that uses a polled interface, come up with > lame INPUT_POLLDEV wrapper shims, or simply accept the fact that drivers > using optional interfaces are going to have to have those interfaces > built in to the kernel. Thanks for weighing-in. >From the statements that Dmitry has made [1] [2], I gather that a separate driver is preferred. But I realized this too late. I've tested the recent re-send of "[PATCH 09/18] input: add input driver for polled GPIO buttons" by Gabor Juhos [3] with this patch series and it works well. The changes needed in this patch series are minimal. I have some review comments for the gpio_buttons patch that I will be posting shortly. The upshot is there will be no need for Kconfig entries for both INPUT_POLLDEV and KEYBOARD_GPIO in arch/arm/mach-davinci, just one to enable the gpio_buttons driver. -- Best Regards, Ben Gardiner [1] http://article.gmane.org/gmane.linux.kernel.input/14044 [2] http://article.gmane.org/gmane.linux.kernel.input/16478 [3] http://article.gmane.org/gmane.linux.kernel.input/16610 --- Nanometrics Inc. http://www.nanometrics.ca -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
