Hi Ben, On Fri, Nov 19, 2010 at 21:08:10, Ben Gardiner wrote: > On Fri, Nov 19, 2010 at 4:58 AM, Nori, Sekhar <nsekhar@xxxxxx> wrote: > > [...] > > On Wed, Nov 17, 2010 at 01:09:35, Ben Gardiner wrote: > >> [...] > >> Changes since v1: > >> * set INPUT_POLLDEV default for DA850_EVM machine, but don't select it > >> unconditionally > > > > I didn't see the v1 posting (wonder why), but why is this > > required? Why cant we depend on this being selected from > > Device Drivers->Input device support in menuconfig? > > I'm sorry about that. I checked gmane and the v1 never made it to the > davinci-linux list. I think it was because of my (mis)use of git > send-email. Version 2 made it to the list so I've now found the magic > incantation. > > The reason we should at least select INPUT_POLLDEV as a default option > is: when it is not set the gpio-keys instances registered by the > da850-evm board setup routine will fail probe() of the gpio-keys > driver since it will not have polled-input support enabled. > > By setting INPUT_POLLDEV default for the da850-evm users will get > functioning pushbuttons and switches with the default config but they > will be able to disable INPUT_POLLDEV or gpio-keys drivers in their > defconfig at their convenience. I guess we could also just modify the defconfig to switch on INPUT_POLLDEV? Since only gpio-keys functionality is affected by not enabling the correct options in kernel, it should be OK. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
