Re: [PATCH 1/3] Input: hgpk - enable advanced mode through module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

On Sat, Oct 02, 2010 at 09:42:34PM +0100, Daniel Drake wrote:
> +
> +	/*
> +	 * The first packet after the finger goes down only establishes the
> +	 * baseline for relative movement.
> +	 * (ignore possibility of finger going down and button being pressed
> +	 * simultaneously.)
> +	 */
> +	if (!priv->isdown) {
> +		priv->abs_x = *x;
> +		priv->abs_y = *y;
> +		priv->isdown = true;
> +		return false;
> +	}
> +
> +	tmp = *x; *x -= priv->abs_x; priv->abs_x = tmp;
> +	tmp = *y; *y -= priv->abs_y; priv->abs_y = tmp;

Why do you use abs->rel conversion in driver and not rely on the
standard userspace component handling thouchpads in absolute mode?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux