dmitry wrote:
> Hi Daniel,
>
> On Sat, Oct 02, 2010 at 09:42:34PM +0100, Daniel Drake wrote:
> > +
> > + /*
> > + * The first packet after the finger goes down only establishes the
> > + * baseline for relative movement.
> > + * (ignore possibility of finger going down and button being pressed
> > + * simultaneously.)
> > + */
> > + if (!priv->isdown) {
> > + priv->abs_x = *x;
> > + priv->abs_y = *y;
> > + priv->isdown = true;
> > + return false;
> > + }
> > +
> > + tmp = *x; *x -= priv->abs_x; priv->abs_x = tmp;
> > + tmp = *y; *y -= priv->abs_y; priv->abs_y = tmp;
>
> Why do you use abs->rel conversion in driver and not rely on the
> standard userspace component handling thouchpads in absolute mode?
the driver can (and does, on user request)) switch modes between
"glidesensor" and "pen tablet" mode on the fly. (userspace requests
this with a write to the "ptmode" sysfs node). changing the device
from relative to absolute at that point would also require that
userspace close/reopen, or use a separate device, wouldn't it?
paul
>
> Thanks.
>
> --
> Dmitry
=---------------------
paul fox, pgf@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
