On Saturday 30 January 2010, Dmitry Torokhov wrote: > On Sat, Jan 30, 2010 at 07:41:20AM +0100, Arnd Bergmann wrote: > > The change looks good, but the same driver also uses the BKL in the > > default_llseek function. It would be nice to get rid of that in the > > same patch, e.g. by adding a ".llseek = generic_file_llseek," line > > in the file_operations, or making it call nonseekable_open() if the > > driver does not require seek to do anything. > > > > I am afraid you mixed up the drivers, I don't see uinput implementing > seek... Sorry, I should have been clearer, but not implementing llseek is the problem I was referring to: When a driver has no explicit .llseek operation in its file operations and does not call nonseekable_open from its open operation, the VFS layer will implicitly use default_llseek, which takes the BKL. We're in the process of changing drivers not to do this, one by one so we can kill the BKL in the end. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
