On Sat, Jan 30, 2010 at 07:41:20AM +0100, Arnd Bergmann wrote: > On Friday 29 January 2010, Thadeu Lima de Souza Cascardo wrote: > > Commit 8702965848ed4bee27486a3e3d2ae34ebba6dd83 has push down the BKL > > into uinput open function. However, there's nothing that needs locking > > in there. > > > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> > > The change looks good, but the same driver also uses the BKL in the > default_llseek function. It would be nice to get rid of that in the > same patch, e.g. by adding a ".llseek = generic_file_llseek," line > in the file_operations, or making it call nonseekable_open() if the > driver does not require seek to do anything. > I am afraid you mixed up the drivers, I don't see uinput implementing seek... Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
