On Tue, Sep 22, 2009 at 03:56, Jiri Kosina wrote: > On Tue, 22 Sep 2009, Hennerich, Michael wrote: > >> >It actually doesn't seem to be the same condition (KP_INT vs. KR_INT), >> >but it's difficult to say, as these constants are apparently added in >> >some other patch I have no idea about. >> >> KP Key-Press versus Key-Release >> >> >And the same for other constants used in the code ... the patch seems to >> >be quite incomplete. >> >> The missing constants are in include/linux/mfd/adp5520.h >> >> This file was sent in a different patch, adding support for the Multi Function Device Core >> (drivers/mfd/adp5520.c) > > The dependency on another patch should be either at least expressed in the > patch Changelog, or even better send the patches as series with proper > numbering, so that the dependency is obvious. we've already been over this. read the whole thread and/or search lkml for the mfd patch. the followup will contain the dependency info, but until then, the exact define values really arent relevant to review of this code. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
