Re: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs

[Jiri Kosina <jkosina@xxxxxxx>]

On Mon, 21 Sep 2009, Dmitry Torokhov wrote:

> > +	if (event & KP_INT) {
> > +		adp5520_read(dev->master, KP_INT_STAT_1, &reg_val_low);
> > +		adp5520_read(dev->master, KP_INT_STAT_2, &reg_val_high);
> > +
> > +		keymask = (reg_val_high << 8) | reg_val_low;
> > +		/* Read twice to clear */
> > +		adp5520_read(dev->master, KP_INT_STAT_1, &reg_val_low);
> > +		adp5520_read(dev->master, KP_INT_STAT_2, &reg_val_high);
> > +		keymask |= (reg_val_high << 8) | reg_val_low;
> > +		adp5520_keys_report_event(dev, keymask, 1);
> > +	}
> > +
> > +	if (event & KR_INT) {
> 
> Why do you check the same condition twice?

It actually doesn't seem to be the same condition (KP_INT vs. KR_INT), but 
it's difficult to say, as these constants are apparently added in some 
other patch I have no idea about.
And the same for other constants used in the code ... the patch seems to 
be quite incomplete.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html