On Thu, Jul 17, 2008 at 12:05:11PM -0400, Dmitry Torokhov wrote: > On Tue, Jul 15, 2008 at 01:04:36PM +0200, Thomas Bogendoerfer wrote: > > This driver adds support for the volume buttons on the front of every > > SGI Indy and O2 workstation. > > Looks very nice. Do you think we could pass a pointer to > button_status() in device's platform data and get rid of ifdefs > altogether? it's doable, but would need an extra header file for declaring a struct for passing the button_status() function pointer. If you think that's worth it, I'll implement it. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ] -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html