On Thu, Jul 17, 2008 at 07:38:35PM +0200, Thomas Bogendoerfer wrote: > On Thu, Jul 17, 2008 at 12:05:11PM -0400, Dmitry Torokhov wrote: > > On Tue, Jul 15, 2008 at 01:04:36PM +0200, Thomas Bogendoerfer wrote: > > > This driver adds support for the volume buttons on the front of every > > > SGI Indy and O2 workstation. > > > > Looks very nice. Do you think we could pass a pointer to > > button_status() in device's platform data and get rid of ifdefs > > altogether? > > it's doable, but would need an extra header file for declaring > a struct for passing the button_status() function pointer. If > you think that's worth it, I'll implement it. > I think it is OK as is for now. If we ever want to add yet another button flavor then I would request this change. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
