On 06/01/2025 08:22, Yu-Hsian Yang wrote: >>> --- >>> .../bindings/iio/adc/nuvoton,nct7201.yaml | 49 +++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 50 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml >>> new file mode 100644 >>> index 000000000000..08b52258e4af >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml >>> @@ -0,0 +1,49 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct7201.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Nuvoton nct7201 and similar ADCs >>> + >>> +maintainers: >>> + - Eason Yang <j2anfernee@xxxxxxxxx> >>> + >>> +description: | >>> + Family of ADCs with i2c interface. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - nuvoton,nct7201 >>> + - nuvoton,nct7202 >> >> Devices aren't compatible? Explain in the commit msg why they aren't or >> use proper compatibility (oneOf, see numerous other bindings or example-schema). >> >> > > + compatible: > - enum: > - - nuvoton,nct7201 > - - nuvoton,nct7202 > + oneOf: > + - const: nuvoton,nct7201 > + - const: nuvoton,nct7202 Nothing improved. I referenced 'oneOf' for the case of compatibility. Don't use it to code enum in different way. Address the comment and questions. You did not respond to several comments, so I assume you are going to implement/fix all of pointed out things. Best regards, Krzysztof
