On Thu, Dec 26, 2024 at 01:53:12PM +0800, Eason Yang wrote: > Adds a binding specification for the Nuvoton NCT7201/NCT7202 I gave you link to exact line with exact text to use. Read it again and use it, instead inventing your own wording. The documentation does not say "Adds" but explicitly asks you to say "Add". Why using different? Subject: nothing improved. > > Signed-off-by: Eason Yang <j2anfernee@xxxxxxxxx> > --- > .../bindings/iio/adc/nuvoton,nct7201.yaml | 49 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > new file mode 100644 > index 000000000000..08b52258e4af > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct7201.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton nct7201 and similar ADCs > + > +maintainers: > + - Eason Yang <j2anfernee@xxxxxxxxx> > + > +description: | > + Family of ADCs with i2c interface. > + > +properties: > + compatible: > + enum: > + - nuvoton,nct7201 > + - nuvoton,nct7202 Devices aren't compatible? Explain in the commit msg why they aren't or use proper compatibility (oneOf, see numerous other bindings or example-schema). > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + description: > + Reset pin for the device. Drop description, obvious. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@1d { > + compatible = "nuvoton,nct7202"; > + reg = <0x1d>; Make the example complete: add interrupts and reset-gpios. Best regards, Krzysztof
