On Wed, 2024-11-13 at 22:05 +0200, Andy Shevchenko wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Nov 13, 2024 at 1:48 PM <victor.duicu@xxxxxxxxxxxxx> wrote: > > > > From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx> > > > > This patch implements ACPI support to Microchip pac1921. > > The driver can read the shunt resistor value and label from the > > ACPI table. > > > > Signed-off-by: Victor Duicu <victor.duicu@xxxxxxxxxxxxx> > Hi Andy, > ... > > > Differences related to previous versions: > > v10: > > - fix coding style mistakes. > > - add UL to PAC1921_MAX_SHUNT_VALUE_uOHMS. > > - edit comment in pac1921_write_shunt_resistor. > > - in pac1921_probe use is_acpi_device_node instead of > > ACPI_HANDLE. > > Any explanation why my tag was not included? Haven't you addressed > all > the things I pointed out? If not, care to elaborate why? > My sincere apologies, I haven't realised that you have given your review-by tag in the last reply. I will send the patch again. > -- > With Best Regards, > Andy Shevchenko With Best Regards, Duicu Victor
