On Wed, Nov 13, 2024 at 1:48 PM <victor.duicu@xxxxxxxxxxxxx> wrote: > > From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx> > > This patch implements ACPI support to Microchip pac1921. > The driver can read the shunt resistor value and label from the ACPI table. > > Signed-off-by: Victor Duicu <victor.duicu@xxxxxxxxxxxxx> ... > Differences related to previous versions: > v10: > - fix coding style mistakes. > - add UL to PAC1921_MAX_SHUNT_VALUE_uOHMS. > - edit comment in pac1921_write_shunt_resistor. > - in pac1921_probe use is_acpi_device_node instead of > ACPI_HANDLE. Any explanation why my tag was not included? Haven't you addressed all the things I pointed out? If not, care to elaborate why? -- With Best Regards, Andy Shevchenko